mq: restore _branchtags() fast path (issue3223) Since a5917346c72e, mq saves the nodeid of the first applied patch to cache/branchheads, which breaks the optimized cache handling introduced in fbf8320f25c8. The problem is the revision being committed is appended to mqrepo.applied after the commit succeeds, which means mqrepo._branchtags() performs a regular update and write the first applied patch to the branch cache. One solution is to set a context variable _committingpatch on the mqrepo while it is committing a patch and to take it in account when deciding to fast-path mqrepo._branchtags(). Not really elegant but it works. The changes to test-mq-caches.t reverse changes introduced by a5917346c72e. The cache should not have been updated with mq records. The changes to test-keyword.t are indirectly caused by a5917346c72e. Reported and analyzed by Yuya Nishihara <yuya@tcha.org> Notes: - qpush still makes a slow path _branchtags() call when checking heads. Maybe this can be optimized. - be careful when merging this patch in default as secretcommit() was renamed newcommit() right after the end of the code freeze. [ original upstream message ]

     1

#!/usr/bin/env python

     2

     3

"""This does HTTP GET requests given a host:port and path and returns

     4

a subset of the headers plus the body of the result."""

     5

     6

import httplib, sys, re

     7

     8

try:

     9

    import msvcrt, os

    10

    msvcrt.setmode(sys.stdout.fileno(), os.O_BINARY)

    11

    msvcrt.setmode(sys.stderr.fileno(), os.O_BINARY)

    12

except ImportError:

    13

    pass

    14

    15

headers = [h.lower() for h in sys.argv[3:]]

    16

conn = httplib.HTTPConnection(sys.argv[1])

    17

conn.request("GET", sys.argv[2])

    18

response = conn.getresponse()

    19

print response.status, response.reason

    20

for h in headers:

    21

    if response.getheader(h, None) is not None:

    22

        print "%s: %s" % (h, response.getheader(h))

    23

print

    24

data = response.read()

    25

sys.stdout.write(data)

    26

    27

if 200 <= response.status <= 299:

    28

    sys.exit(0)

    29

sys.exit(1)