test: comparison hgkw/keyword.py

equal deleted inserted replaced

-:45d3ea301c03
+:3d882f14f23a
 def utcdate(date):
 '''Returns hgdate in cvs-like UTC format.'''
 return time.strftime('%Y/%m/%d %H:%M:%S', time.gmtime(date[0]))
-_kwtemplater = _cmd = _cmdoptions = None
+# make keyword tools accessible
+kwtools = {'templater': None, 'hgcmd': None}
 # store originals of monkeypatches
 _patchfile_init = patch.patchfile.__init__
 _patch_diff = patch.diff
 _dispatch_parse = dispatch._parse
 def _kwpatchfile_init(self, ui, fname, missing=False):
 '''Monkeypatch/wrap patch.patchfile.__init__ to avoid
 rejects or conflicts due to expanded keywords in working dir.'''
 _patchfile_init(self, ui, fname, missing=missing)
-if _kwtemplater.matcher(self.fname):
+# shrink keywords read from working dir
-# shrink keywords read from working dir
+kwt = kwtools['templater']
-kwshrunk = _kwtemplater.shrink(''.join(self.lines))
+self.lines = kwt.shrinklines(self.fname, self.lines)
-self.lines = kwshrunk.splitlines(True)
 def _kw_diff(repo, node1=None, node2=None, files=None, match=util.always,
 fp=None, changes=None, opts=None):
-# only expand if comparing against working dir
+'''Monkeypatch patch.diff to avoid expansion except when
+comparing against working dir.'''
 if node2 is not None:
-_kwtemplater.matcher = util.never
+kwtools['templater'].matcher = util.never
-if node1 is not None and node1 != repo.changectx().node():
+elif node1 is not None and node1 != repo.changectx().node():
-_kwtemplater.restrict = True
+kwtools['templater'].restrict = True
 _patch_diff(repo, node1=node1, node2=node2, files=files, match=match,
 fp=fp, changes=changes, opts=opts)
 def _kwweb_changeset(web, req, tmpl):
 '''Wraps webcommands.changeset turning off keyword expansion.'''
-_kwtemplater.matcher = util.never
+kwtools['templater'].matcher = util.never
 return web.changeset(tmpl, web.changectx(req))
 def _kwweb_filediff(web, req, tmpl):
 '''Wraps webcommands.filediff turning off keyword expansion.'''
-_kwtemplater.matcher = util.never
+kwtools['templater'].matcher = util.never
 return web.filediff(tmpl, web.filectx(req))
 def _kwdispatch_parse(ui, args):
 '''Monkeypatch dispatch._parse to obtain running hg command.'''
-global _cmd
+cmd, func, args, options, cmdoptions = _dispatch_parse(ui, args)
-_cmd, func, args, options, cmdoptions = _dispatch_parse(ui, args)
+kwtools['hgcmd'] = cmd
-return _cmd, func, args, options, cmdoptions
+return cmd, func, args, options, cmdoptions
 # dispatch._parse is run before reposetup, so wrap it here
 dispatch._parse = _kwdispatch_parse
 'Source': '{root}/{file},v',
 'Id': '{file|basename},v {node|short} {date|utcdate} {author|user}',
 'Header': '{root}/{file},v {node|short} {date|utcdate} {author|user}',
 }
-def __init__(self, ui, repo, inc, exc, hgcmd):
+def __init__(self, ui, repo, inc, exc):
 self.ui = ui
 self.repo = repo
 self.matcher = util.matcher(repo.root, inc=inc, exc=exc)[1]
-self.restrict = hgcmd in restricted.split()
+self.restrict = kwtools['hgcmd'] in restricted.split()
-self.commitnode = None
-self.path = ''
 kwmaps = self.ui.configitems('keywordmaps')
 if kwmaps: # override default templates
 kwmaps = [(k, templater.parsestring(v, quoted=False))
 for (k, v) in kwmaps]
 templatefilters.filters['utcdate'] = utcdate
 self.ct = cmdutil.changeset_templater(self.ui, self.repo,
 False, '', False)
-def substitute(self, node, data, subfunc):
+def getnode(self, path, fnode):
-'''Obtains file's changenode if commit node not given,
+'''Derives changenode from file path and filenode.'''
-and calls given substitution function.'''
+# used by kwfilelog.read and kwexpand
-if self.commitnode:
+c = context.filectx(self.repo, path, fileid=fnode)
-fnode = self.commitnode
+return c.node()
-else:
-c = context.filectx(self.repo, self.path, fileid=node)
+def substitute(self, data, path, node, subfunc):
-fnode = c.node()
+'''Replaces keywords in data with expanded template.'''
 def kwsub(mobj):
-'''Substitutes keyword using corresponding template.'''
 kw = mobj.group(1)
 self.ct.use_template(self.templates[kw])
 self.ui.pushbuffer()
-self.ct.show(changenode=fnode, root=self.repo.root, file=self.path)
+self.ct.show(changenode=node, root=self.repo.root, file=path)
 ekw = templatefilters.firstline(self.ui.popbuffer())
 return '$%s: %s $' % (kw, ekw)
 return subfunc(kwsub, data)
-def expand(self, node, data):
+def expand(self, path, node, data):
 '''Returns data with keywords expanded.'''
-if self.restrict or util.binary(data):
+if not self.restrict and self.matcher(path) and not util.binary(data):
-return data
+changenode = self.getnode(path, node)
-return self.substitute(node, data, self.re_kw.sub)
+return self.substitute(data, path, changenode, self.re_kw.sub)
+return data
-def process(self, node, data, expand):
-'''Returns a tuple: data, count.
+def iskwfile(self, path, islink):
-Count is number of keywords/keyword substitutions,
+'''Returns true if path matches [keyword] pattern
-telling caller whether to act on file containing data.'''
+and is not a symbolic link.
-if util.binary(data):
+Caveat: localrepository._link fails on Windows.'''
-return data, None
+return self.matcher(path) and not islink(path)
-if expand:
-return self.substitute(node, data, self.re_kw.subn)
+def overwrite(self, node=None, expand=True, files=None):
-return data, self.re_kw.search(data)
+'''Overwrites selected files expanding/shrinking keywords.'''
+ctx = self.repo.changectx(node)
-def shrink(self, text):
+mf = ctx.manifest()
+if node is not None:     # commit
+files = [f for f in ctx.files() if f in mf]
+notify = self.ui.debug
+else:                    # kwexpand/kwshrink
+notify = self.ui.note
+candidates = [f for f in files if self.iskwfile(f, mf.linkf)]
+if candidates:
+self.restrict = True # do not expand when reading
+candidates.sort()
+action = expand and 'expanding' or 'shrinking'
+for f in candidates:
+fp = self.repo.file(f)
+data = fp.read(mf[f])
+if util.binary(data):
+continue
+if expand:
+changenode = node or self.getnode(f, mf[f])
+data, found = self.substitute(data, f, changenode,
+self.re_kw.subn)
+else:
+found = self.re_kw.search(data)
+if found:
+notify(_('overwriting %s %s keywords\n') % (f, action))
+self.repo.wwrite(f, data, mf.flags(f))
+self.repo.dirstate.normal(f)
+self.restrict = False
+def shrinktext(self, text):
+'''Unconditionally removes all keyword substitutions from text.'''
+return self.re_kw.sub(r'$\1$', text)
+def shrink(self, fname, text):
 '''Returns text with all keyword substitutions removed.'''
-if util.binary(text):
+if self.matcher(fname) and not util.binary(text):
-return text
+return self.shrinktext(text)
-return self.re_kw.sub(r'$\1$', text)
+return text
+def shrinklines(self, fname, lines):
+'''Returns lines with keyword substitutions removed.'''
+if self.matcher(fname):
+text = ''.join(lines)
+if not util.binary(text):
+return self.shrinktext(text).splitlines(True)
+return lines
+def wread(self, fname, data):
+'''If in restricted mode returns data read from wdir with
+keyword substitutions removed.'''
+return self.restrict and self.shrink(fname, data) or data
 class kwfilelog(filelog.filelog):
 '''
 Subclass of filelog to hook into its read, add, cmp methods.
 Keywords are "stored" unexpanded, and processed on reading.
 '''
 def __init__(self, opener, path):
 super(kwfilelog, self).__init__(opener, path)
-_kwtemplater.path = path
+self.kwt = kwtools['templater']
+self.path = path
-def kwctread(self, node, expand):
-'''Reads expanding and counting keywords, called from _overwrite.'''
-data = super(kwfilelog, self).read(node)
-return _kwtemplater.process(node, data, expand)
 def read(self, node):
 '''Expands keywords when reading filelog.'''
 data = super(kwfilelog, self).read(node)
-return _kwtemplater.expand(node, data)
+return self.kwt.expand(self.path, node, data)
 def add(self, text, meta, tr, link, p1=None, p2=None):
 '''Removes keyword substitutions when adding to filelog.'''
-text = _kwtemplater.shrink(text)
+text = self.kwt.shrink(self.path, text)
 return super(kwfilelog, self).add(text, meta, tr, link, p1=p1, p2=p2)
 def cmp(self, node, text):
 '''Removes keyword substitutions for comparison.'''
-text = _kwtemplater.shrink(text)
+text = self.kwt.shrink(self.path, text)
 if self.renamed(node):
 t2 = super(kwfilelog, self).read(node)
 return t2 != text
 return revlog.revlog.cmp(self, node, text)
-def _iskwfile(f, link):
+def _status(ui, repo, kwt, *pats, **opts):
-return not link(f) and _kwtemplater.matcher(f)
-def _status(ui, repo, *pats, **opts):
 '''Bails out if [keyword] configuration is not active.
 Returns status of working directory.'''
-if _kwtemplater:
+if kwt:
 files, match, anypats = cmdutil.matchpats(repo, pats, opts)
 return repo.status(files=files, match=match, list_clean=True)
 if ui.configitems('keyword'):
 raise util.Abort(_('[keyword] patterns cannot match'))
 raise util.Abort(_('no [keyword] patterns configured'))
-def _overwrite(ui, repo, node=None, expand=True, files=None):
-'''Overwrites selected files expanding/shrinking keywords.'''
-ctx = repo.changectx(node)
-mf = ctx.manifest()
-if node is not None:   # commit
-_kwtemplater.commitnode = node
-files = [f for f in ctx.files() if f in mf]
-notify = ui.debug
-else:                  # kwexpand/kwshrink
-notify = ui.note
-candidates = [f for f in files if _iskwfile(f, mf.linkf)]
-if candidates:
-candidates.sort()
-action = expand and 'expanding' or 'shrinking'
-for f in candidates:
-fp = repo.file(f, kwmatch=True)
-data, kwfound = fp.kwctread(mf[f], expand)
-if kwfound:
-notify(_('overwriting %s %s keywords\n') % (f, action))
-repo.wwrite(f, data, mf.flags(f))
-repo.dirstate.normal(f)
 def _kwfwrite(ui, repo, expand, *pats, **opts):
-'''Selects files and passes them to _overwrite.'''
+'''Selects files and passes them to kwtemplater.overwrite.'''
-status = _status(ui, repo, *pats, **opts)
+kwt = kwtools['templater']
+status = _status(ui, repo, kwt, *pats, **opts)
 modified, added, removed, deleted, unknown, ignored, clean = status
 if modified or added or removed or deleted:
 raise util.Abort(_('outstanding uncommitted changes in given files'))
 wlock = lock = None
 try:
 wlock = repo.wlock()
 lock = repo.lock()
-_overwrite(ui, repo, expand=expand, files=clean)
+kwt.overwrite(expand=expand, files=clean)
 finally:
 del wlock, lock
 def demo(ui, repo, *args, **opts):
 Crosscheck which files in working directory are potential targets for
 keyword expansion.
 That is, files matched by [keyword] config patterns but not symlinks.
 '''
-status = _status(ui, repo, *pats, **opts)
+kwt = kwtools['templater']
+status = _status(ui, repo, kwt, *pats, **opts)
 modified, added, removed, deleted, unknown, ignored, clean = status
 files = modified + added + clean
 if opts.get('untracked'):
 files += unknown
 files.sort()
 wctx = repo.workingctx()
 islink = lambda p: 'l' in wctx.fileflags(p)
-kwfiles = [f for f in files if _iskwfile(f, islink)]
+kwfiles = [f for f in files if kwt.iskwfile(f, islink)]
 cwd = pats and repo.getcwd() or ''
 kwfstats = not opts.get('ignore') and (('K', kwfiles),) or ()
 if opts.get('all') or opts.get('ignore'):
 kwfstats += (('I', [f for f in files if f not in kwfiles]),)
 for char, filenames in kwfstats:
 Wraps commit to overwrite configured files with updated
 keyword substitutions.
 This is done for local repos only, and only if there are
 files configured at all for keyword substitution.'''
-global _kwtemplater
 try:
-if (not repo.local() or _cmd in nokwcommands.split()
+if (not repo.local() or kwtools['hgcmd'] in nokwcommands.split()
 or '.hg' in util.splitpath(repo.root)
 or repo._url.startswith('bundle:')):
 return
 except AttributeError:
 pass
 else:
 exc.append(pat)
 if not inc:
 return
-_kwtemplater = kwtemplater(ui, repo, inc, exc, _cmd)
+kwtools['templater'] = kwt = kwtemplater(ui, repo, inc, exc)
 class kwrepo(repo.__class__):
-def file(self, f, kwmatch=False):
+def file(self, f):
 if f[0] == '/':
 f = f[1:]
-if kwmatch or _kwtemplater.matcher(f):
+return kwfilelog(self.sopener, f)
-return kwfilelog(self.sopener, f)
-return filelog.filelog(self.sopener, f)
 def wread(self, filename):
 data = super(kwrepo, self).wread(filename)
-if _kwtemplater.restrict and _kwtemplater.matcher(filename):
+return kwt.wread(filename, data)
-return _kwtemplater.shrink(data)
-return data
 def commit(self, files=None, text='', user=None, date=None,
 match=util.always, force=False, force_editor=False,
 p1=None, p2=None, extra={}, empty_ok=False):
 wlock = lock = None
 # restore commit hooks
 for name, cmd in commithooks.iteritems():
 ui.setconfig('hooks', name, cmd)
 if node is not None:
-_overwrite(ui, self, node=node)
+kwt.overwrite(node=node)
 repo.hook('commit', node=node, parent1=_p1, parent2=_p2)
 return node
 finally:
 del wlock, lock

branch	stable
changeset 418	3d882f14f23a
parent 416	b69dca43ef08
child 419	2f179ea3a9aa