# HG changeset patch
# User Bryan O'Sullivan <bryano@fb.com>
# Date 1354043911 28800
# Node ID 8ed9a9f075f9d299a719c7be9a5a5fe078b34a7d
# Parent  d5d13134793af5567cb118f3b5619aa056ce885e
run-tests: make build command line less intimidating

Use a dict for parameters to the format string, instead of a
ridiculous number of positional parameters.

[ original upstream message ]

diff -r d5d13134793a -r 8ed9a9f075f9 tests/run-tests.py
--- a/tests/run-tests.py	Wed Nov 14 18:08:39 2012 -0600
+++ b/tests/run-tests.py	Tue Nov 27 11:18:31 2012 -0800
@@ -384,12 +384,14 @@
         # least on Windows for now, deal with .pydistutils.cfg bugs
         # when they happen.
         nohome = ''
-    cmd = ('%s setup.py %s clean --all'
-           ' build --build-base="%s"'
-           ' install --force --prefix="%s" --install-lib="%s"'
-           ' --install-scripts="%s" %s >%s 2>&1'
-           % (sys.executable, pure, os.path.join(HGTMP, "build"),
-              INST, PYTHONDIR, BINDIR, nohome, installerrs))
+    cmd = ('%(exe)s setup.py %(pure)s clean --all'
+           ' build --build-base="%(base)s"'
+           ' install --force --prefix="%(prefix)s" --install-lib="%(libdir)s"'
+           ' --install-scripts="%(bindir)s" %(nohome)s >%(logfile)s 2>&1'
+           % dict(exe=sys.executable, pure=pure, 
+                  base=os.path.join(HGTMP, "build"),
+                  prefix=INST, libdir=PYTHONDIR, bindir=BINDIR, 
+                  nohome=nohome, logfile=installerrs))
     vlog("# Running", cmd)
     if os.system(cmd) == 0:
         if not options.verbose: