prevent transient leaks of file handle by using new helper functions stable
authorDan Villiom Podlaski Christiansen <danchr@gmail.com>
Mon, 02 May 2011 10:11:18 +0200 (2011-05-02)
branchstable
changeset 929 9bed13113742
parent 928 e1bf64aaef4f
child 930 730303014491
prevent transient leaks of file handle by using new helper functions These leaks may occur in environments that don't employ a reference counting GC, i.e. PyPy. This implies: - changing opener(...).read() calls to opener.read(...) - changing opener(...).write() calls to opener.write(...) - changing open(...).read(...) to util.readfile(...) - changing open(...).write(...) to util.writefile(...) [ original upstream description ]
hgkw/keyword.py
--- a/hgkw/keyword.py	Mon May 02 19:20:29 2011 +0200
+++ b/hgkw/keyword.py	Mon May 02 10:11:18 2011 +0200
@@ -413,7 +413,7 @@
     demoitems('keywordset', ui.configitems('keywordset'))
     demoitems('keywordmaps', kwmaps.iteritems())
     keywords = '$' + '$\n$'.join(sorted(kwmaps.keys())) + '$\n'
-    repo.wopener(fn, 'w').write(keywords)
+    repo.wopener.write(fn, keywords)
     repo[None].add([fn])
     ui.note(_('\nkeywords written to %s:\n') % fn)
     ui.note(keywords)